Press n or j to go to the next uncovered block, b, p or k for the previous block.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 | 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 29x 29x 29x 29x 29x 29x 29x 29x 29x 29x 29x 29x 29x 29x 29x 29x 29x 29x 1x 1x 9x 9x 9x 9x 9x 9x 9x 9x 9x 9x 9x 9x 9x 9x 9x 9x 9x 9x 9x 9x 1x 1x 9x 9x 9x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x 1x | CLASS ltcl_run_checks DEFINITION DEFERRED. CLASS zcl_abapgit_repo_status DEFINITION LOCAL FRIENDS ltcl_run_checks. CLASS ltcl_util DEFINITION FOR TESTING RISK LEVEL HARMLESS DURATION SHORT FINAL. PUBLIC SECTION. CLASS-METHODS check_contains IMPORTING ii_log TYPE REF TO zif_abapgit_log iv_pattern TYPE string. ENDCLASS. CLASS ltcl_util IMPLEMENTATION. METHOD check_contains. DATA lt_messages TYPE zif_abapgit_log=>ty_log_outs. DATA ls_message LIKE LINE OF lt_messages. DATA lv_contains TYPE abap_bool. lt_messages = ii_log->get_messages( ). LOOP AT lt_messages INTO ls_message. IF ls_message-text CP iv_pattern. lv_contains = abap_true. EXIT. ENDIF. ENDLOOP. cl_abap_unit_assert=>assert_equals( act = lv_contains exp = abap_true ). ENDMETHOD. ENDCLASS. CLASS ltcl_run_checks DEFINITION FOR TESTING RISK LEVEL HARMLESS DURATION SHORT FINAL. PUBLIC SECTION. INTERFACES zif_abapgit_sap_package. INTERFACES zif_abapgit_sap_namespace. PRIVATE SECTION. DATA: mt_results TYPE zif_abapgit_definitions=>ty_results_tt, mo_instance TYPE REF TO lcl_status_consistency_checks, mo_dot TYPE REF TO zcl_abapgit_dot_abapgit, mi_log TYPE REF TO zif_abapgit_log. METHODS: append_result IMPORTING iv_obj_type TYPE trobjtype iv_obj_name TYPE sobj_name iv_match TYPE abap_bool iv_lstate TYPE char1 iv_rstate TYPE char1 iv_package TYPE devclass iv_path TYPE string iv_filename TYPE string iv_packmove TYPE abap_bool OPTIONAL, setup, teardown, positive FOR TESTING RAISING zcx_abapgit_exception, neg_diff_path_for_same_obj FOR TESTING RAISING zcx_abapgit_exception, neg_incorrect_path_vs_pack FOR TESTING RAISING zcx_abapgit_exception, neg_similar_filenames FOR TESTING RAISING zcx_abapgit_exception, neg_empty_filenames FOR TESTING RAISING zcx_abapgit_exception, package_move FOR TESTING RAISING zcx_abapgit_exception, check_namespace FOR TESTING RAISING zcx_abapgit_exception, check_namespace_aff FOR TESTING RAISING zcx_abapgit_exception, check_sub_package FOR TESTING RAISING zcx_abapgit_exception. ENDCLASS. CLASS ltcl_run_checks IMPLEMENTATION. METHOD zif_abapgit_sap_package~validate_name. RETURN. ENDMETHOD. METHOD zif_abapgit_sap_package~get_default_transport_layer. RETURN. ENDMETHOD. METHOD zif_abapgit_sap_package~read_responsible. RETURN. ENDMETHOD. METHOD zif_abapgit_sap_package~read_description. RETURN. ENDMETHOD. METHOD zif_abapgit_sap_package~list_subpackages. RETURN. ENDMETHOD. METHOD zif_abapgit_sap_package~list_superpackages. RETURN. ENDMETHOD. METHOD zif_abapgit_sap_package~read_parent. rv_parentcl = '$MAIN'. ENDMETHOD. METHOD zif_abapgit_sap_package~create_child. RETURN. ENDMETHOD. METHOD zif_abapgit_sap_package~get. RETURN. ENDMETHOD. METHOD zif_abapgit_sap_package~exists. rv_bool = abap_true. ENDMETHOD. METHOD zif_abapgit_sap_package~are_changes_recorded_in_tr_req. RETURN. ENDMETHOD. METHOD zif_abapgit_sap_package~get_transport_type. RETURN. ENDMETHOD. METHOD zif_abapgit_sap_package~create. RETURN. ENDMETHOD. METHOD zif_abapgit_sap_package~create_local. RETURN. ENDMETHOD. METHOD zif_abapgit_sap_namespace~exists. rv_yes = boolc( iv_namespace <> 'NOTEXIST' ). ENDMETHOD. METHOD zif_abapgit_sap_namespace~is_editable. ENDMETHOD. METHOD zif_abapgit_sap_namespace~split_by_name. ENDMETHOD. METHOD append_result. DATA ls_result LIKE LINE OF mt_results. ls_result-inactive = abap_false. ls_result-obj_type = iv_obj_type. ls_result-obj_name = iv_obj_name. ls_result-match = iv_match. ls_result-lstate = iv_lstate. ls_result-rstate = iv_rstate. ls_result-package = iv_package. ls_result-path = iv_path. ls_result-filename = iv_filename. ls_result-packmove = iv_packmove. APPEND ls_result TO mt_results. ENDMETHOD. METHOD setup. CREATE OBJECT mi_log TYPE zcl_abapgit_log. mo_dot = zcl_abapgit_dot_abapgit=>build_default( ). mo_dot->set_starting_folder( '/' ). " assumed by unit tests zcl_abapgit_injector=>set_sap_package( iv_package = '$MAIN' ii_sap_package = me ). zcl_abapgit_injector=>set_sap_package( iv_package = '$MAIN_SUB' ii_sap_package = me ). zcl_abapgit_injector=>set_sap_namespace( me ). CREATE OBJECT mo_instance EXPORTING iv_root_package = '$Z$' io_dot = mo_dot. ENDMETHOD. METHOD teardown. DATA li_empty TYPE REF TO zif_abapgit_sap_namespace. zcl_abapgit_injector=>set_sap_namespace( li_empty ). ENDMETHOD. METHOD positive. " 0 Positive append_result( iv_obj_type = 'CLAS' iv_obj_name = 'ZCLASS1' iv_match = ' ' iv_lstate = ' ' iv_rstate = 'A' iv_package = '$Z$' iv_path = '/' iv_filename = 'zclass1.clas.abap' ). append_result( iv_obj_type = 'CLAS' iv_obj_name = 'ZCLASS1' iv_match = 'X' iv_lstate = ' ' iv_rstate = ' ' iv_package = '$Z$' iv_path = '/' iv_filename = 'zclass1.clas.xml' ). append_result( iv_obj_type = 'DOMA' iv_obj_name = 'ZDOMA1' iv_match = 'X' iv_lstate = ' ' iv_rstate = ' ' iv_package = '$Z$' iv_path = '/' iv_filename = 'zdoma1.doma.xml' ). append_result( iv_obj_type = 'DOMA' iv_obj_name = 'ZDOMA2' iv_match = ' ' iv_lstate = 'M' iv_rstate = ' ' iv_package = '$Z$' iv_path = '/' iv_filename = 'zdoma2.doma.xml' ). mi_log = mo_instance->run_checks( mt_results ). cl_abap_unit_assert=>assert_equals( act = mi_log->count( ) exp = 0 ). ENDMETHOD. METHOD neg_diff_path_for_same_obj. " 1 Negative, different path for same object append_result( iv_obj_type = 'CLAS' iv_obj_name = 'ZCLASS1' iv_match = ' ' iv_lstate = ' ' iv_rstate = 'A' iv_package = '$Z$' iv_path = '/' iv_filename = 'zclass1.clas.abap' ). append_result( iv_obj_type = 'CLAS' iv_obj_name = 'ZCLASS1' iv_match = 'X' iv_lstate = ' ' iv_rstate = ' ' iv_package = '$Z$' iv_path = '/sub' iv_filename = 'zclass1.clas.xml' ). append_result( iv_obj_type = 'DOMA' iv_obj_name = 'ZDOMA1' iv_match = 'X' iv_lstate = ' ' iv_rstate = ' ' iv_package = '$Z$' iv_path = '/' iv_filename = 'zdoma1.doma.xml' ). append_result( iv_obj_type = 'DOMA' iv_obj_name = 'ZDOMA2' iv_match = ' ' iv_lstate = 'M' iv_rstate = ' ' iv_package = '$Z$' iv_path = '/' iv_filename = 'zdoma2.doma.xml' ). mi_log = mo_instance->run_checks( mt_results ). " This one is not pure - incorrect path also triggers path vs package check cl_abap_unit_assert=>assert_equals( act = mi_log->count( ) exp = 2 ). ltcl_util=>check_contains( ii_log = mi_log iv_pattern = |Files for object *| ). ENDMETHOD. METHOD neg_incorrect_path_vs_pack. " 2 Negative, incorrect path vs package append_result( iv_obj_type = 'CLAS' iv_obj_name = '$$ZCLASS1' iv_match = ' ' iv_lstate = ' ' iv_rstate = 'A' iv_package = '$Z$' iv_path = '/' iv_filename = '$$zclass1.clas.abap' ). append_result( iv_obj_type = 'CLAS' iv_obj_name = '$$ZCLASS1' iv_match = 'X' iv_lstate = ' ' iv_rstate = ' ' iv_package = '$Z$' iv_path = '/' iv_filename = '$$zclass1.clas.xml' ). append_result( iv_obj_type = 'DOMA' iv_obj_name = '$$ZDOMA1' iv_match = 'X' iv_lstate = ' ' iv_rstate = ' ' iv_package = '$Z$' iv_path = '/sub' iv_filename = '$$zdoma1.doma.xml' ). append_result( iv_obj_type = 'DOMA' iv_obj_name = '$$ZDOMA2' iv_match = ' ' iv_lstate = 'M' iv_rstate = ' ' iv_package = '$Z$' iv_path = '/' iv_filename = '$$zdoma2.doma.xml' ). mi_log = mo_instance->run_checks( mt_results ). cl_abap_unit_assert=>assert_equals( act = mi_log->count( ) exp = 1 ). ltcl_util=>check_contains( ii_log = mi_log iv_pattern = |Package and path do not match for object*| ). ENDMETHOD. METHOD neg_similar_filenames. " 3 Negative, similar filenames append_result( iv_obj_type = 'CLAS' iv_obj_name = '$$ZCLASS1' iv_match = ' ' iv_lstate = ' ' iv_rstate = 'A' iv_package = '$Z$' iv_path = '/' iv_filename = '$$zclass1.clas.abap' ). append_result( iv_obj_type = 'CLAS' iv_obj_name = '$$ZCLASS1' iv_match = 'X' iv_lstate = ' ' iv_rstate = ' ' iv_package = '$Z$' iv_path = '/' iv_filename = '$$zclass1.clas.xml' ). append_result( iv_obj_type = 'DOMA' iv_obj_name = '$$ZDOMA1' iv_match = 'X' iv_lstate = ' ' iv_rstate = ' ' iv_package = '$Z$' iv_path = '/' iv_filename = '$$zdoma1.doma.xml' ). append_result( iv_obj_type = 'DOMA' iv_obj_name = '$$ZDOMA2' iv_match = ' ' iv_lstate = 'M' iv_rstate = ' ' iv_package = '$Z$' iv_path = '/' iv_filename = '$$zdoma1.doma.xml' ). mi_log = mo_instance->run_checks( mt_results ). cl_abap_unit_assert=>assert_equals( act = mi_log->count( ) exp = 1 ). ltcl_util=>check_contains( ii_log = mi_log iv_pattern = |Multiple files with same filename, *| ). ENDMETHOD. METHOD neg_empty_filenames. " 4 Negative, empty filenames append_result( iv_obj_type = 'CLAS' iv_obj_name = '$$ZCLASS1' iv_match = ' ' iv_lstate = ' ' iv_rstate = 'A' iv_package = '$Z$' iv_path = '/' iv_filename = '$$zclass1.clas.abap' ). append_result( iv_obj_type = 'CLAS' iv_obj_name = '$$ZCLASS1' iv_match = 'X' iv_lstate = ' ' iv_rstate = ' ' iv_package = '$Z$' iv_path = '/' iv_filename = '$$zclass1.clas.xml' ). append_result( iv_obj_type = 'DOMA' iv_obj_name = '$$ZDOMA1' iv_match = 'X' iv_lstate = ' ' iv_rstate = ' ' iv_package = '$Z$' iv_path = '/' iv_filename = '' ). mi_log = mo_instance->run_checks( mt_results ). cl_abap_unit_assert=>assert_equals( act = mi_log->count( ) exp = 1 ). ltcl_util=>check_contains( ii_log = mi_log iv_pattern = |Filename is empty for object *| ). ENDMETHOD. METHOD package_move. " 5 Changed package assignment append_result( iv_obj_type = 'CLAS' iv_obj_name = 'ZCLASS1' iv_match = ' ' iv_lstate = ' ' iv_rstate = 'A' iv_package = '$Z$' iv_path = '/' iv_filename = 'zclass1.clas.abap' iv_packmove = 'X' ). append_result( iv_obj_type = 'CLAS' iv_obj_name = 'ZCLASS1' iv_match = ' ' iv_lstate = 'A' iv_rstate = ' ' iv_package = '$Z$SUB' iv_path = '/sub' iv_filename = 'zclass1.clas.abap' iv_packmove = 'X' ). append_result( iv_obj_type = 'CLAS' iv_obj_name = 'ZCLASS1' iv_match = ' ' iv_lstate = ' ' iv_rstate = 'A' iv_package = '$Z$' iv_path = '/' iv_filename = 'zclass1.clas.xml' iv_packmove = 'X' ). append_result( iv_obj_type = 'CLAS' iv_obj_name = 'ZCLASS1' iv_match = ' ' iv_lstate = 'A' iv_rstate = ' ' iv_package = '$Z$SUB' iv_path = '/sub' iv_filename = 'zclass1.clas.xml' iv_packmove = 'X' ). append_result( iv_obj_type = 'DOMA' iv_obj_name = 'ZDOMA1' iv_match = ' ' iv_lstate = 'A' iv_rstate = ' ' iv_package = '$Z$' iv_path = '/' iv_filename = 'zdoma1.doma.xml' iv_packmove = 'X' ). append_result( iv_obj_type = 'DOMA' iv_obj_name = 'ZDOMA2' iv_match = ' ' iv_lstate = ' ' iv_rstate = 'A' iv_package = '$Z$SUB' iv_path = '/sub' iv_filename = 'zdoma1.doma.xml' iv_packmove = 'X' ). mi_log = mo_instance->run_checks( mt_results ). " Three files, but only two msg (for two changed objects) cl_abap_unit_assert=>assert_equals( act = mi_log->count( ) exp = 2 ). ltcl_util=>check_contains( ii_log = mi_log iv_pattern = |Changed package assignment for object*| ). ENDMETHOD. METHOD check_namespace. " 6 Missing namespace append_result( iv_obj_type = 'CLAS' iv_obj_name = '/NOTEXIST/ZCLASS1' iv_match = ' ' iv_lstate = ' ' iv_rstate = 'A' iv_package = '/NOTEXIST/Z' iv_path = '/' iv_filename = '#notexist#zclass1.clas.xml' ). CREATE OBJECT mo_instance EXPORTING iv_root_package = '/NOTEXIST/Z' io_dot = mo_dot. mi_log = mo_instance->run_checks( mt_results ). cl_abap_unit_assert=>assert_equals( act = mi_log->count( ) exp = 1 ). ltcl_util=>check_contains( ii_log = mi_log iv_pattern = |Namespace *| ). ENDMETHOD. METHOD check_namespace_aff. " 6 Missing namespace append_result( iv_obj_type = 'CLAS' iv_obj_name = '/NOTEXIST/ZCLASS1' iv_match = ' ' iv_lstate = ' ' iv_rstate = 'A' iv_package = '/NOTEXIST/Z' iv_path = '/' iv_filename = '(notexist)zclass1.clas.json' ). CREATE OBJECT mo_instance EXPORTING iv_root_package = '/NOTEXIST/Z' io_dot = mo_dot. mi_log = mo_instance->run_checks( mt_results ). cl_abap_unit_assert=>assert_equals( act = mi_log->count( ) exp = 1 ). ltcl_util=>check_contains( ii_log = mi_log iv_pattern = |Namespace *| ). ENDMETHOD. METHOD check_sub_package. append_result( iv_obj_type = 'DEVC' iv_obj_name = '$MAIN' iv_match = 'X' iv_lstate = ' ' iv_rstate = ' ' iv_package = '$MAIN' iv_path = '/' iv_filename = 'package.devc.xml' ). append_result( iv_obj_type = 'DEVC' iv_obj_name = '$MAIN_SUB' iv_match = ' ' iv_lstate = ' ' iv_rstate = 'X' iv_package = '' iv_path = '' iv_filename = 'package.devc.xml' ). CREATE OBJECT mo_instance EXPORTING iv_root_package = '$MAIN' io_dot = mo_dot. mi_log = mo_instance->run_checks( mt_results ). cl_abap_unit_assert=>assert_equals( act = mi_log->count( ) exp = 1 ). ltcl_util=>check_contains( ii_log = mi_log iv_pattern = |Package $MAIN_SUB already exists but is not a sub-package of $MAIN*| ). ENDMETHOD. ENDCLASS. |